Fix Sid Meier's Civilization crash (Issue #4511) #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For somehow building the Windows installer failed, but the test build in my repository finished by success, so this PR is ready to be merged. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4505 made Sid Meier's Civilization on Linux to crash as mentioned in Issue #4511.
This PR fixes the crash, and confirmed that it doesn't crash and goes to the next step.
Tried on Windows VS x64 build and Arch Linux SDL2 builds.
What issue(s) does this PR address?
Fixes #4511
Additional information
Confirmed that this doesn't affect Chess Master 3000 as mentioned in Issue #4510.
Title.000.mp4
And SETCOLOR command working as expected.
