Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input in configuration tool (SDL2) #4629

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

maron2000
Copy link
Contributor

While you can edit your settings using Configuration Tool, the characters you see when you type with Shift-key was messy.
This is due to that SDL2 provides correct keycode if Shift-key is NOT pressed, but provide incorrect keycode if Shift is pressed.
As a result, you find some keys not possible to type with a non-US keyboard.

This PR will make all keys act as US keyboards for the time being so that at least you can type all common symbols.
We can further fix this if we can find out a way that SDL2 will provide the keycode when Shift-key is pressed.
Also, keypad keys were not working, so made it work.

Test result on JP keyboard
Before fix
Shift+1,2,3 is !@#, as same as US keyboard.
Shift+P,@,[ is P@{ which is not correct. (Shift+@ is not @)
before

After fix
P,@,[ on JP keyboard is P,[,]
Shift+ P,@,[ is P,{, }
after

@joncampbell123 joncampbell123 merged commit 71c10e2 into joncampbell123:master Nov 24, 2023
17 checks passed
@maron2000 maron2000 deleted the buildmd_fix branch December 12, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants