Add loongarch64 support #4891
Merged
Add loongarch64 support #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper loongarch64 support
Recognize loongarch64 as 64-bit
loongarch64 is 64-bit
This was referenced Mar 11, 2024
xen0n
reviewed
Mar 11, 2024
include/version_string.h
Outdated
| @@ -57,7 +57,7 @@ | |||
| #define OS_PLATFORM_LONG "" | |||
| #endif | |||
|
|
|||
| #if defined(_M_X64) || defined (_M_AMD64) || defined (_M_ARM64) || defined (_M_IA64) || defined(__ia64__) || defined(__LP64__) || defined(_WIN64) || defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) | |||
| #if defined(_M_X64) || defined (_M_AMD64) || defined (_M_ARM64) || defined (_M_IA64) || defined(__ia64__) || defined(__LP64__) || defined(_WIN64) || defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) || defined(__loongarch64__) | |||
There was a problem hiding this comment.
No need for this addition: LoongArch64 is covered by the __LP64__ test already.
src/libs/libchdr/lzma/CpuArch.h
Outdated
| @@ -83,6 +83,14 @@ MY_CPU_LE_UNALIGN means that CPU is LITTLE ENDIAN and CPU supports unaligned mem | |||
| #endif | |||
|
|
|||
|
|
|||
| #if defined(__loongarch64) \ | |||
| || defined(__loongarch64__) | |||
There was a problem hiding this comment.
Please just test for __loongarch_lp64. The __loongarch64 name is deprecated while __loongarch64__ has never been included in any platform spec.
src/libs/libchdr/lzma/CpuArch.h
Outdated
| @@ -140,6 +148,7 @@ MY_CPU_LE_UNALIGN means that CPU is LITTLE ENDIAN and CPU supports unaligned mem | |||
| || defined(__MIPSEL__) \ | |||
| || defined(__MIPSEL) \ | |||
| || defined(_MIPSEL) \ | |||
| || defined(MY_CPU_LOONGARCH64) \ | |||
There was a problem hiding this comment.
No need to test this either, the last check is generic enough to catch LoongArch.
src/misc/savestates.cpp
Outdated
| @@ -277,7 +277,7 @@ std::string GetPlatform(bool save) { | |||
| #endif | |||
| ); | |||
| if (!save) strcat(platform, (std::string(SDL_STRING)+", ").c_str()); | |||
| #if defined(_M_X64) || defined (_M_AMD64) || defined (_M_ARM64) || defined (_M_IA64) || defined(__ia64__) || defined(__LP64__) || defined(_WIN64) || defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) | |||
| #if defined(_M_X64) || defined (_M_AMD64) || defined (_M_ARM64) || defined (_M_IA64) || defined(__ia64__) || defined(__LP64__) || defined(_WIN64) || defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) || defined(__loongarch64__) | |||
There was a problem hiding this comment.
Similarly here: the __LP64__ check suffices.
configure.ac
Outdated
| @@ -630,6 +630,12 @@ case "$host_cpu" in | |||
| c_targetcpu="m68k" | |||
| c_unalignedmemory=yes | |||
| ;; | |||
| loongarch64*) | |||
| AC_DEFINE(C_TARGETCPU,LOONGARCH64) | |||
| AC_MSG_RESULT(Loongson 3A5000+) | |||
There was a problem hiding this comment.
Maybe just "LoongArch"? Even if just considering Loongson products, this expression excludes the 2K product line, which may not be what you mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add loongarch64 identifiers in
configure.acandversion_string.h, making loongarch64 a "supported" architecture.Also enable MT32 support on loongarch64.