-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reported size issues in builtin DIR command #4973
Conversation
- mounted a SMB share to a drive letter, the correct free space is shown - purges the 1919 MB freesize cap limit - -freesize switch is honored (tested WIN32 version only)
Fix lowend build issues
Revert back unnecessary changes in AllocationInfo
Great! |
Partial testing:
Haven't tested yet:
Can't test:
|
@Torinde The free size is limited in other ways, as you can see: Perhaps I have to remove all that code? For the SMB share, I created a network share on the same 8 TB VHDX I've mounted for the other test. |
Further notes for possible code reorganization: localDrive::localDrive constructor takes these fake params, passed as uint16_t and uint8_t. Max possible size is 65535 clusters and, we know, DOS knows very little about 4Kn sectors or big (>32K) clusters... In drives.h, struct allocation (member of localDrive) should perhaps be enhanced to 64-bit, to track modern disk quantities. Appropriate members (AllocationInfo, AllocationInfo32) should translate those sizes as needed by "real" DOS apps. |
@Torinde I made a newer commit https://github.com/maxpat78/dosbox-x/tree/cmd_dir_patch with artifacts to allow |
Thanks, @maxpat78, I'll test it (but not immediately) and report back. |
-freesize
switch is honored(tested WIN32 version only, with an 8TB VHDX drive)
Closes #4004
Closes #4258