CFGTOOL: Windows themes

[aybe]

Additional information

Finally figured out CONTROL.INI nonsense, OLE colors in wrong order! 😫

For what's been upgraded, I simplified drawing code drastically by using fill rects...

I also added a visualizer for GUI::String... it took me ages to notice chars are 4 bytes... 💀🤣

Border is 1:1, menu almost done, the rest will be very long... (next time)

The original Windows 3.1 themes:

[aybe]

Not sure on how to fix these linux/mac errors...

[Torinde]

I enjoy all the recent CFGTOOL updates, thanks!

LCD Default seems closest to the DOSbox-X theme, but its borders are blue instead of gray:
(from #5108)

Can you add one like that?
And one "modern dark", e.g. white letters on black/dark background.

What about a .conf setting to choose the theme + auto setting "match host OS theme"?

[aybe]

The original was based on 16-color mode, had to switch to 24-bit as color panel swatches were so confusing; then I realized that indeed it's different. It shouldn't be too hard to add it back.

Dark mode is hard, although you can easily come up with one, I found it more looking like high-contrast, it's not easy to come up with the right balance of colors.

Last things are on the list but before that, the rest of the interface must be ported to that new scheme first.

[aybe]

There you go, all it needs now is a "theme guru" to craft nice ones.

[Torinde]

Thanks, @aybe!

Tangentially related - is there a setting to change the DOSbox menu look - graphical (as on these screenshots) vs text-based?

[joncampbell123]

Oooh, nice! You got the menu bar to look like Windows 3.1 too! 👍

That looks way closer to what Windows 3.1 actually looks like! So now every window looks like WS_DIALOG, which is perfectly fine.

[aybe]

Thanks, @aybe!

Tangentially related - is there a setting to change the DOSbox menu look - graphical (as on these screenshots) vs text-based?

Obviously, LCD Dark looks terrible and one really needs a true dark skin... I suppose I'll try again at some point.

Just noticed a bug in the theme menu which gets overridden by section editor...

The banner you mean? [dosbox[ bannercolortheme

Oooh, nice! You got the menu bar to look like Windows 3.1 too! 👍

That looks way closer to what Windows 3.1 actually looks like! So now every window looks like WS_DIALOG, which is perfectly fine.

At the moment, borders, title bar, buttons, focus are 1:1, everything else has to be done.

Though nice, these old themes have a big problem, button color is always the same...

While fixing, I will DRY the code first like I did for the buttons, then adjust.

[joncampbell123]

One thing you should consider is that the menu bar in Windows 3.1 has a line below it to visually separate it from the client area of the window. Can that be done?

[aybe]

Yes I know, I just wanted to get theme in first to see how well it would work with actual code.

[Torinde]

The banner you mean?

No, I mean the menu of the DOSbox-X window itself:
Graphic:

Text:

Can those be chosen via .conf or dosbox-x.exe argument?

Also, after the recent changes - when closing Configuration tool window the main DOSbox window goes to the center of the screen. Builds from 1 month ago don't do that. Maybe related: #3612

And - DOSbox-X window in TTF mode now is a little bigger than in builds from 1 month ago, just enough so that the title bar is outside the screen (above the top) - I see Main/CPU/Video/etc., but not the _ [] X (laptop I'm trying that on is with high resolution internal screen with 200% scaling and lower resolution external one with no scaling and in such situation Windows OS acts in various undesirable ways... so probably TTF being too big is to blame on my setup. But difference between DOSbox-X builds is enough to make it extra annoying, e.g. to reach the title bar in the latest build I have to go through full screen... then I can see the top, but not the bottom of the window :))

[aybe]

1. comes from OS?
2. haven't seen it for ages
3. yes, it fixed some cases but broke others
4. rough guess, comes from fixed/sizable Win32 behavior

[joncampbell123]

The choice of menu is a compile time option. The idea is to use what the OS provides, or if that is not possible, to draw it's own. It's not something that can be changed by a dosbox.conf option.

[aybe]

It took me a while to figure out why menu height was -858,993,460... 💀

Windows 3.1 has no 3D window with a menu, I checked everywhere, you'll get stock thickness:

[joncampbell123]

It took me a while to figure out why menu height was -858,993,460... 💀

Windows 3.1 has no 3D window with a menu, I checked everywhere, you'll get stock thickness:

That's how I remember it too.

[aybe]

Two things,

First, it is impossible to redo that transparency effect for menu shadow:

Second, I don't know where to find these 3D checkboxes, indeed they're familiar but they're not in Windows 3.1:

[aybe]

never mind, I just remembered you posted one... good old sound forge :)

[aybe]

One thing with CTL3D is that it doesn't propagate theme:

Original:

?