Fix some Linux issues in VHD code #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids Linux incompatibilities uising uint16_t instead of wchar_t
VHDMAKE now allows absolute pathnames in differencing images under Linux like under Windows. Absolute pathnames should be avoided since they prevents exchanging VHD images between OSes, however.
|
Awesome! Do VHD images work correctly on your end with this change? |
|
On Windows 11, new VHD code works fine, as usual. On Linux, I've tried GitHub built artifact with Windows 11 WSL. VHDMAKE works as expected, except for the differencing VHD created in a subdirectory, which can't get mounted:
The reason is that only parent file name, not full relative path, gets stored in the VHD locator sector (both Linux & Windows): I'll try to fix this when I'll have more time. |
A new VHD child image locator now stores absolute pathname to parent, allowing child images lay in subdirectories
try to fix realpath use on non-Windows platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5132 and #5143 and possibly #5145