Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sharp-bilinear Direct3D shader #5163

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

RibShark
Copy link
Contributor

@RibShark RibShark commented Aug 8, 2024

This adds a sharp-bilinear shader for Direct3D.

What issue(s) does this PR address?

None that I can see.

Does this PR introduce new feature(s)?

Yes, a new Direct3D shader (roughly equivalent to the "sharp" OpenGL shader).

Does this PR introduce any breaking change(s)?

No.

Additional information

Requires #5161.

@joncampbell123 joncampbell123 merged commit de810a4 into joncampbell123:master Aug 9, 2024
19 of 20 checks passed
@BridgeHeadland
Copy link

As someone who likes sharp images, what is the difference between Direct 3D and OpenGL output like that otherwise?

@RibShark
Copy link
Contributor Author

RibShark commented Aug 9, 2024

As someone who likes sharp images, what is the difference between Direct 3D and OpenGL output like that otherwise?

it should be mostly identical, but OpenGL has a bug (#3073) that prevents aspect correction when shaders are used, so I wanted to get this shader in D3D which isn't affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants