Clean up warnings and resolved issues #5199
Conversation
Allofich
changed the title
|
We should also probably close old issues about build failures, as they become less relevant as time passes and the codebase changes. Closes #2886. |
|
I think issues where there is a likely explanation offered by testers that have looked into the issue that is not the fault of DOSBox-X and the original reporter isn't responding are also fair game for closing. They can always be re-opened if it turns out there actually is a problem. Closes #4747. |
|
There are also old "documentation" tagged issues buried in the issues page. Those should probably be moved to the wiki or converted to discussions or something. |
|
Let's also close any unworkable issues: |
Add a summary of the change(s) brought by this PR here.
What issue(s) does this PR address?
The project has a lot of compile warnings (especially -Wsuggest-override warnings in cdrom.h appear frequently) and there are many resolved-yet-open issues.
Through merging this PR, you can close these issues, which appear to have been resolved:
Closes #1746.
Closes #4977.
Closes #4398.
Closes #2826.
Closes #3345.
Closes #2829.
Closes #2733.
Closes #2869.
Closes #3451.
Closes #4209. (Consensus seems to have been that the problem was not in DOSBox-X)
Closes #2663.
Closes #2787.
Closes #2252. (I don't completely understand this issue from a quick read but there seems to be consensus that the problem was not in DOSBox-X)
Closes #3016.
Closes #1285.
Closes #1822.
Closes #5069.
Closes #3979.
Closes #835.
Closes #1780.
Closes #2589.
Closes #886.
Does this PR introduce new feature(s)?
No.
Does this PR introduce any breaking change(s)?
No.
There is also the question of how to handle all the "Question"-tagged issues in the Issues page. For example in #3483, @maron2000 suggests closing the issue (a "Question" issue) because it had been answered. We could do that, or convert them to Discussions (see https://docs.github.com/en/discussions/managing-discussions-for-your-community/managing-discussions#converting-issues-based-on-labels). We could also leave them as they are, but I feel they are cluttering the Issues page.