Decouple CMS and OPL emulations from dosbox-staging

[RNMB15]

Add a summary of the change(s) brought by this PR here.

What issue(s) does this PR address?

If there are any related issues, reference them here. Ex. #1234, Fixes #1234, Closes #1234, etc.

Does this PR introduce new feature(s)?

If yes, describe the feature(s) introduced.

Does this PR introduce any breaking change(s)?

If yes, describe the breaking change(s) in detail.

Additional information

Add any additional information here.

[RNMB15]

Decouple CMS and OPL emulations from dosbox-staging.

japsmits/dosbox-staging@bc7d5fd

[maron2000]

const char* Set_CMS[]={"on", "off", "auto"};

[Allofich]

To make it like the DosBox Staging commit, in src/hardware/sblaster.cpp you need to change:

line 3721
from
else if (!strcasecmp(omode,"cms")) opl_mode=OPL_cms;
to
else if (!strcasecmp(omode,"cms")) {} // Skip for backward compatibility with existing configurations

line 3736
from
opl_mode=OPL_cms;
to
opl_mode=OPL_none;

In struct SB_INFO add
bool cms;

Somewhere, such as right after the switch (oplmode) at line 3975 ends (at line 4005), add:

		sb.cms = is_cms_enabled();
		if (cms) {
			CMS_Init(section);
		}

And in the destructor ~SBLASTER(), immediately after the switch there add

		if (sb.cms) {
			CMS_ShutDown(m_configuration);
		}

I haven't tested these changes. Currently this PR is not compiling, I don't know if the above changes will fix that.

Also, DOSBox-X has an additional isCMSpassthrough variable. I'm not sure if that needs to be accounted for somehow or can be ignored.

[Allofich]

You put things within switch statements. When I wrote things like "immediately after the switch," I didn't mean immediately after the line with "switch" in it, I meant after the closing brace of the switch statement. Also you put bool cms; in a switch statement, instead of in struct SB_INFO.

Also I guess you are making your changes through the GitHub editor, which produces "Update xxx" commit messages, but descriptive commit messages are preferable. You can make those with a program like Git Bash, although learning to use it can take some time.

Anyway, I think it would be better to let me make a new PR with the changes. I'll try to do it soon.

[joncampbell123]

It looks like CI failed. Is this pull request separate from the other one about CMS and OPL?

[joncampbell123]

Should I close this one and merge the newer pull request? At a glance they do basically the same thing, except that this failed the build test.

[Allofich]

Yes, you can close this one.