-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Improve cells #200
Merged
Merged
MRG: Improve cells #200
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
166c1ce
ENH: remove unused methods
jasmainak 6650d81
DOC: fix docstring
jasmainak 5231256
MAINT: consolidate biophys for soma and dend into one method
jasmainak 1d69221
WIP: try to load geometry
jasmainak 434a78e
DOC more documentation and separating Neuron specific attributes
jasmainak e3e6270
Units
jasmainak 10c6d9c
Refactor topology
jasmainak eeacc0c
Remove method for scaling
jasmainak b28a628
Backtrack on reading geo files
jasmainak ff7ba7e
Remove function to get scales for real
jasmainak fdeb0e9
init in parent class?
jasmainak 4495b26
FIX scale
jasmainak 8f96d1a
MAINT: _biophysics -> set_biophysics
jasmainak 93b57b3
MAINT: consolidate move_to_pos
jasmainak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describing nrn objects with floats and ints shows up in several docstrings. Is this just referencing the numerical argument that instantiates the object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be documented wrongly :-) fix is always welcome!
btw,
soma(0.5)
just means the middle of thesoma
... I guess you know that already but putting it out there in case that was not clear.