Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Refactor BatchSimulate Example and Improve Documentation #857

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ENH: Refactor BatchSimulate Example and Improve Documentation #857

wants to merge 8 commits into from

Conversation

samadpls
Copy link
Contributor

@samadpls samadpls commented Aug 10, 2024 •
edited
Loading

Adjusted parameter descriptions and added more informative explanations for waveforms and simulation outputs.

@samadpls samadpls force-pushed the feat/batch_simulation branch 2 times, most recently from 27fcbb6 to 86a68e8 Compare August 10, 2024 19:50
ntolley
ntolley reviewed Aug 12, 2024
View reviewed changes
hnn_core/batch_simulate.py Outdated Show resolved Hide resolved
@samadpls samadpls force-pushed the feat/batch_simulation branch 2 times, most recently from 719b17f to 455d5b7 Compare August 13, 2024 12:41
@samadpls samadpls changed the title ENH: BatchSimulate to Handle JSON File Paths ENH: BatchSimulate to Avoid Redundant Network Saving Aug 14, 2024
ntolley
ntolley reviewed Aug 15, 2024
View reviewed changes
hnn_core/batch_simulate.py Outdated Show resolved Hide resolved
ntolley
ntolley reviewed Aug 15, 2024
View reviewed changes
hnn_core/batch_simulate.py Outdated Show resolved Hide resolved
@samadpls samadpls force-pushed the feat/batch_simulation branch 11 times, most recently from a0a1a47 to bb511df Compare August 17, 2024 20:12
@samadpls samadpls changed the title ENH: BatchSimulate to Avoid Redundant Network Saving ENH: Refactor BatchSimulate Example and Improve Documentation Sep 10, 2024
@ntolley
Copy link
Contributor

ntolley commented Oct 14, 2024

@samadpls I tried testing BatchSimulate with trial based parallelism (as opposed to MPI). Locally I'm seeing it run each trial sequence, can you confirm if this is happening on your computer?

samadpls and others added 7 commits October 19, 2024 22:46
@samadpls
Copy link
Contributor Author

Yes, sorry for the delay. It looks like Joblib wasn’t being used for simulate_dipole before. I’ve added it now, and it’s running in parallel properly. It should work for you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntolley ntolley ntolley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samadpls @ntolley