-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Added GSoC 2024 acknowledgment to author section #874
Conversation
@@ -12,6 +12,8 @@ | |||
# Nick Tolley <[email protected]> | |||
# Ryan Thorpe <[email protected]> | |||
# Mainak Jas <[email protected]> | |||
# | |||
# This project was supported by Google Summer of Code (GSoC) 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a GSoC requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jasmainak, I received a suggestion from @ntolley to include a statement in the author section of the example notebook, referencing that the project was supported by GSoC, per their guidelines.
I'm open to any further suggestions or adjustments you'd like to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to have an explicit section of funding ... it has been supported on the HNN grant, I have been supported on the MNE-Python grant etc. So we're acknowledging all funding sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would belong on an About
page or something? We can chat with Steph to get a full list of funding sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mne-python has a dedicated page: https://github.com/mne-tools/mne-python/blob/3f1c7803f73862dec3e4e85e36e916f2a6d642c9/doc/funding.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made an issue #881 !
Signed-off-by: samadpls <[email protected]>
9b914b7
to
2e4966d
Compare
No description provided.