Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Update Network eq method #902

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[MRG] Update Network eq method #902

merged 2 commits into from
Oct 17, 2024

Commits on Oct 9, 2024

  1. refactor: updated Network eq method to avoid listing methods to ignore 

    Previously any new method added to the Network object had to be added to a hardcoded list to ignore making a comparison. Using var() instead of dir() to get at only the attributes avoids this by only accessing the attributes and not all attributes and methods.
    @gtdang
    gtdang committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    dc1e97c View commit details
    Browse the repository at this point in the history

  2. refactor: updated check_equal_networks method to avoid listing method… 

    …s to ignore

Previously any new method added to the Network object had to be added to a hardcoded list to ignore making a comparison. Using var() instead of dir() to get at only the attributes avoids this by only accessing the attributes and not all attributes and methods.
    @gtdang
    gtdang committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d2e6dee View commit details
    Browse the repository at this point in the history