[WIP] Flip specified drives in input histogram #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to invert about the y axis when plotting the input histogram
…in plot_spikes_hist in viz.py
…ts to invert about the y axis when plotting the input histogram
…in plot_spikes_hist in viz.py
|
can you add a tiny unit test to check that the inverted axis is indeed added? |
samadpls
reviewed
Oct 19, 2024
| if invert_spike_types is None: | ||
| invert_spike_types = list() | ||
| else: | ||
| if isinstance(invert_spike_types, dict): |
There was a problem hiding this comment.
Suggested change
| if isinstance(invert_spike_types, dict): | |
| if not isinstance(invert_spike_types, (str, list)): |
Hi Dylan, Great PR.. Just a small suggestion: in the type check for invert_spike_types, instead of raising a TypeError only when it's a dict, it would be clearer to ensure it's either a string or a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality to specify spike types to invert when creating the input histogram.
So far:
Still need to test, etc. More coming soon :)