Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix synapses properties rendering #913

Merged

Conversation

gtdang
Copy link
Collaborator

@gtdang gtdang commented Oct 18, 2024

Changed logic in _update_cell_params_vbox to properly build the cell_parameters_key.

The problem was here:

hnn-core/hnn_core/gui/gui.py

Lines 1974 to 1975 in 7a42650

if "Biophysics" or 'Geometry' in cell_layer:
cell_parameters_key += f" {cell_type.split(' ')[0]}"

if "Biophysics" will always evaluate to True.

closes #911

@gtdang gtdang marked this pull request as ready for review October 18, 2024 21:13
@asoplata
Copy link
Collaborator

Just double-checked this, yes this solves the issue. Merging.

@asoplata asoplata merged commit d7aad96 into jonescompneurolab:master Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI BUG: Synapse radio button does not do anything
2 participants