[WIP] Fix Freq in GUI PSD Plot #914
Conversation
… according to the plot config rather than being hard coded
dylansdaniels
changed the title
| color = ax._get_lines.get_next_color() | ||
| dpls_copied[0].plot_psd(fmin=0, fmax=50, ax=ax, color=color, | ||
| dpls_copied[0].plot_psd(fmin=min_f, fmax=max_f, ax=ax, color=color, |
There was a problem hiding this comment.
This is great! Can you checkout the spectrogram tests associated with #894 to verify that the PSD plot is rendered correctly?
There was a problem hiding this comment.
I just realized there's no test in that PR 😄
|
Might consider renaming the widgets to remove the 'spectral' from the widget names. Before they were specific to the spectrogram plots, but with this change they are not. |
I think it's over-plotting a new line when you click add-plot and then updating the axis. There's no over plotting functionality with the spectrogram, so you need to clear then "add plot" to re-plot the axis. |
|
Yep, you're right, clearing the axis and then re-adding the plot successfully changes the frequency range for the spectrogram too. Because this is needed for Thursday's gamma tutorial and I can't find problems with it, merging. |
Update PSD plot in gui _viz_manager so that min/max frequency are set… according to the plot config rather than being hard coded
See issue #910