Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vcxsrv script #341
base: master
Are you sure you want to change the base?
add vcxsrv script #341
Changes from 8 commits
039779f
80f08d9
862fe3e
bfab4a8
6394148
6401db9
4dbc205
328ebaa
61a23fd
af8cfa0
1cefaa0
c9a182a
c9afb8c
3160c65
de68a6c
a57063c
64761ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to manually specify WSL2?
I think this is installed by default now but we've run into a few folks that had WSL1 and couldn't install docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarification, are u saying folks who already had WSL1 before attempting this installation process were having errors installing docker? Like you said,
wsl --install
should by default install WSL2 so users who are following this tutorial, starting from scratch, should have WSL2 installed.I could add some additional instructions here on how to upgrade from WSL1 to WSL2 if that helps (and mention that WSL2 is required over WSL1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could just say something like:
Note: if WSL is already installed on your computer, please ensure it is WSL2 . WSL1 is incompatible with Docker install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, i'll add that in