Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of AsyncProfiler generated stack trace #183

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

AnderEnder
Copy link
Contributor

@AnderEnder AnderEnder commented Jun 21, 2020

  • based on Async Profiler flamegraph implementation
  • add exception for . case to support correct behavior with another java traces
  • fix test case to support new behaviour
  • add more test cases to test new behavior
  • add integration test with example async-profiler collapsed file

Related: #26
Backport PR(idea): brendangregg/FlameGraph#234

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #183 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   90.53%   90.65%   +0.11%     
==========================================
  Files          17       17              
  Lines        2293     2311      +18     
==========================================
+ Hits         2076     2095      +19     
+ Misses        217      216       -1     
Impacted Files Coverage Δ
src/flamegraph/color/palettes.rs 99.65% <100.00%> (+0.02%) ⬆️
src/flamegraph/color/mod.rs 81.81% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa64a2...921caa1. Read the comment docs.

@AnderEnder AnderEnder force-pushed the support-asyncprofiler-trace branch from 51a1044 to a411e0f Compare June 22, 2020 09:50
@AnderEnder AnderEnder marked this pull request as ready for review June 26, 2020 19:46
@AnderEnder AnderEnder force-pushed the support-asyncprofiler-trace branch from d0018e2 to 1e6fbfe Compare June 26, 2020 19:47
@AnderEnder
Copy link
Contributor Author

@jonhoo, Async-profiler can produce raw output: traces or already collapsed. For this case I received a huge file with traces from async-profiler and I did not find a way to convert it to collapsed format. I made a dumb convertor. Do you think it would be valuable to put this convertor implementation into inferno tool set as well?

@jonhoo
Copy link
Owner

jonhoo commented Jun 26, 2020

Hmm, that's an interesting question.. I don't know enough about the Java async space to really say, but if it's a common enough format, it seems pretty reasonable to add inferno-collapse-java-async.

@AnderEnder AnderEnder force-pushed the support-asyncprofiler-trace branch from 1e6fbfe to 4beb566 Compare June 27, 2020 19:55
@AnderEnder
Copy link
Contributor Author

@jonhoo I asked my friend and did not received the straight answer: use cases are different. I think this question could be moved to an issue and if anyone will require this use case we can implement it.

@AnderEnder AnderEnder force-pushed the support-asyncprofiler-trace branch from 4beb566 to 921caa1 Compare June 27, 2020 20:14
@jonhoo jonhoo merged commit 432d653 into jonhoo:master Jun 29, 2020
@jonhoo
Copy link
Owner

jonhoo commented Oct 6, 2020

Released in 0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants