Fix remaining cargo warnings #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change specifies `.truncate(true)`, to match the behaviour which was likely intended. However, this presents a difference to the previous behaviour, which is equal to `.truncate(false)`.
RedPhoenixQ
pushed a commit
to RedPhoenixQ/inferno
that referenced
this pull request
Oct 28, 2024
This change specifies `.truncate(true)`, to match the behaviour which was likely intended. However, this presents a difference to the previous behaviour, which is equal to `.truncate(false)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all warnings reported by
cargo clippywithout further settings.There is one more warning on this line, due to the experimental lint, which is not supported on stable Rust. This occurs in
cargo testandcargo doc.inferno/src/lib.rs
Line 145 in 726e7f3
The fix in the second commit changes behaviour, though arguably, that was the intended behaviour. Alternatively, using
.truncate(false)would explicitly preserve the current behaviour.