Data architecture #49
Conversation
| date = db.Column(db.Date()) | ||
| overall_mark = db.Column(db.String(56)) | ||
|
|
||
| posting = db.relationship("Posting") |
There was a problem hiding this comment.
Why do you need the relationship and the foreign key?
There was a problem hiding this comment.
Good question! The relationship gives me access to the related objects pythonically, while the foreign key is necessary for the database architecture
app/models.py
Outdated
| email_address = db.Column(db.String(120), unique=True) | ||
| secondary_email_address = db.Column(db.String(120), unique=True) | ||
| joining_date = db.Column(db.Date()) | ||
| completed_fast_stream = db.Column(db.Boolean()) |
There was a problem hiding this comment.
You don't seem to refer overtly to the fast stream anywhere else e.g. calling the repo Graduate Rotator not 'Fast Stream rotator.
If you want the app to be a blueprint which can be used for other graduate schemes, then maybe calling the field completed_graduate_scheme or completed_scheme would be more appropriate?
If not, maybe calling the app 'Fast stream rotator' and being more explicit that it's only for the fast stream would make it clearer?
There was a problem hiding this comment.
Good spot - I'll drop this column
| @@ -0,0 +1 @@ | |||
| Generic single-database configuration. | |||
There was a problem hiding this comment.
Do readmes also need new lines at the end?
app/models.py
Outdated
| first_name = db.Column(db.String(128)) | ||
| last_name = db.Column(db.String(128)) | ||
| email_address = db.Column(db.String(120), unique=True) | ||
| secondary_email_address = db.Column(db.String(120), unique=True) | ||
| joining_date = db.Column(db.Date()) | ||
| completed_fast_stream = db.Column(db.Boolean()) |
There was a problem hiding this comment.
Would any of these need to be not Nullable? e.g. it seems you wouldn't want to initialise a candidate without a name and email?
requirements.txt
Outdated
| gunicorn==20.0.4 | ||
| identify==1.5.5 | ||
| identify==1.5.2 |
There was a problem hiding this comment.
Just curious - why have some of the packages been brought down in version number?
There was a problem hiding this comment.
I suspect it's because another package relies on earlier versions of these packages
app/models.py
Outdated
| description = db.Column(db.Text()) | ||
|
|
||
|
|
||
| class SkillsMixin(object): |
There was a problem hiding this comment.
Good catch - I think I had a very over-complicated plan for this but since I don't currently use it I'll bin it and bring it back if necessary
| migrate = Migrate() | ||
|
|
||
|
|
||
| class IdModel(object): |
There was a problem hiding this comment.
Didn't know you could do this! Just read the docs though and v cool :)
There was a problem hiding this comment.
Isn't it! Saves on some boilerplating
jonodrew
force-pushed
the
data-architecture
branch
3 times, most recently
from
73cf4b0
to
5f0da03
Compare
This is still only an alpha so for the moment I'm only using an SQLite database. It may be a bit annoying later, but it should be enough to get the architecture done.
This commit is the initial design and migration for the data architecture
A diagram, both as a png and UML, of the proposed database structure
jonodrew
force-pushed
the
data-architecture
branch
from
5f0da03
to
c12e427
Compare
This is an initial attempt to form a working data architecture for this project. The aim is:
Posting, which is a combination of a specificRole,Candidate, and point in time