-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup validation tests #3534
cleanup validation tests #3534
Conversation
@@ -576,7 +576,7 @@ a javadoc:Session[] but the lifecycle is shorter: *data is kept for only one req | |||
}); | |||
|
|||
post("/save", ctx -> { | |||
ctx.flash("success", "Item created"); <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just aligning the doc with what we have at the moment. There is no ctx.flash(str,str)
method
@@ -22,12 +22,6 @@ public Bean validateFormBean(@Valid @FormParam Bean bean) { | |||
return bean; | |||
} | |||
|
|||
// todo: revive when flash `toNullable` will be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the type check
@@ -22,12 +22,6 @@ public Bean validateFormBean(@Valid @FormParam Bean bean) { | |||
return bean; | |||
} | |||
|
|||
// todo: revive when flash `toNullable` will be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the type check
Added type verification. Flash, Session, Cookie, and Header params are now restricted to Error message will look like this:
|
just a bit of cleaning