Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user extension as horizontal extension #110

Closed
wants to merge 1 commit into from
Closed

Conversation

laoneo
Copy link
Contributor

@laoneo laoneo commented Jun 8, 2016

Basic user extension which gets the logged in user from the request. PR is connected to #98.

description="COM_CONTENT_FIELD_CREATED_BY_ALIAS_DESC"
default=""
/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this field in the 'article' entity. It will be used as the 'author alias', when connected to 'users'.

Copy link
Contributor Author

@laoneo laoneo Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed as it is added from Users automatically. If you do php installation/demo.php and open http://joomla.box/?id=1&entity=article, then you will see the author field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine the user component not being installed. The article needs an author field anyway. So just re-use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our case, the author field is not a text field but a user relation. So it would be a wrong declaration. I mean it can also be that no user extension is installed at all (that's probably never going to happen) and that the articles are flat files with no author.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In conjunction with a user component, the article's author field becomes the author alias, we know from current com_content, which is a text field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then this fields needs to be renamed to author_alias.

@nibra nibra closed this Jul 3, 2016
@nibra nibra removed the Under Review label Jul 3, 2016
@laoneo
Copy link
Contributor Author

laoneo commented Jul 3, 2016

Would be nice to have a reason why this PR get's closed.

@nibra
Copy link
Member

nibra commented Jul 3, 2016

That happend, because clean-base was turned into master. Please redo (re-open, if possible) the PR against master branch. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants