Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Finder Router: filter out unnecessary query elements #44055

Open
wants to merge 2 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Sep 11, 2024

Summary of Changes

When creating a Smart Search menu item with a filter, the ID of the filter is displayed in the URL after the search has been submitted. This PR refactors the router to remove the unnecessary parameter.

Testing Instructions

  • Have something to search for in your Joomla installation, for example the testing sampledata.
  • Create a filter for Smart Search with some stuff selected.
  • Create a menu item for the Smart Search search view and select the filter in it.
  • Go to the menu item in the frontend and search for something random.

Actual result BEFORE applying this Pull Request

The URL contains a query element like &f=2.

Expected result AFTER applying this Pull Request

The URL does not contain the &f= query element.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Sep 12, 2024

I have tested this item ✅ successfully on cf51a65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.

@fgsw
Copy link

fgsw commented Sep 12, 2024

I have not tested this item.

Saw to late the red marked information /Applications/MAMP/htdocs/components/com_finder/src/Service/Router.php on line 69 /index.php/en/search?f=1&q=joomla" method="get" role="search"> above the search module:
Untitled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.

@fgsw
Copy link

fgsw commented Sep 13, 2024

@Hackwar Same result /Applications/MAMP/htdocs/components/com_finder/src/Service/Router.php on line 69 /index.php/en/search?f=1&q=joomla" method="get" role="search">

@uglyeoin
Copy link
Contributor

uglyeoin commented Oct 8, 2024

@Hackwar I'm here if you need a test on any update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants