[5.3][Performance] Access Rules smart preload, reduce memory use and time for large sites #44078
+114
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02a1018.
|
Will rebase it after upmarge |
Fedik
commented
Sep 14, 2024
Fedik
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
brianteeman
reviewed
Sep 14, 2024
administrator/components/com_categories/src/View/Categories/HtmlView.php
Outdated
Show resolved
Hide resolved
brianteeman
reviewed
Sep 15, 2024
administrator/components/com_categories/src/View/Categories/HtmlView.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43649.
Summary of Changes
Currently while checking access, the
Access::preload()pulling everything from the access table.It is neglectable for small sites, however for large sites it has huge impact on the site performance.
I added a new method for "smart preload", which allows to preload only needed items. And applied this method for most of the com_content views, where it make sense.
Testing Instructions
Create a site with 20k articles (more is better).
Enable debug.
Open article detail or blog view.
Look for memory usage in the debug bar, and for time.
Actual result BEFORE applying this Pull Request
In my test:
memory usage around 45Mb
time 200-300ms
Expected result AFTER applying this Pull Request
In my test:
memory usage around ~12Mb
time ~100ms
Link to documentations
Please select: