Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to a jQuery plugin #11

Merged
merged 9 commits into from
Apr 19, 2013
Merged

Conversation

agirton
Copy link
Collaborator

@agirton agirton commented Apr 19, 2013

These commits change the script to a jQuery plugin to make Hook.js more extendable. I also changed the spinner from a gif to the Hook logo. I'm using css3 animations to spin the logo. Can certainly remove this, and resend pull request if needed. Also the plugin will require the use of mousewheel.js if developer wants support for mouse wheel. Still need to update for using css transitions instead of animate, but this at least a start. Since there is a callback this should fix issue #8. There is no Safari detection so fixes Issue #7. Fixes #6 the infinite reloading through using "window.location.reload(true);". Should also take care of some of the issues in #9 since it supports touch devices and mouse wheel.

Adam Girton and others added 9 commits April 16, 2013 17:08
…l configurable

still need to add AJAX and css transitions
…ck to the slideUp callback

Will be changing this so can use css3 transitions/animations instead of
jQuery animation. Still need to work out the bug where callback is
firing multiple times. Firefox does not like to reload page until mouse
has scrolled down first. May use mouse movements in addition to touch
and mousewheel
Updated readme for current know issues.
Updated assets to use hook as spinner, using css3 animations to spin it.
…dded min file

Also added my name to authors.
@gogobu
Copy link

gogobu commented Apr 19, 2013

Just a thought, could this be used as "Pull to Load More" at the bottom of a listview? An option to do so would be cool.

@agirton
Copy link
Collaborator Author

agirton commented Apr 19, 2013

@gogobu there is a callback called reloadEl that instead of reloading the page will allow you to do run any other javascript you would like, like loading in more HTML.

@gogobu
Copy link

gogobu commented Apr 19, 2013

Sorry I wasn't clear enough. What I meant was instead of pull from the top of the page, a "pull to load more" at the bottom of the page to load more list items. (smile)

jordansinger added a commit that referenced this pull request Apr 19, 2013
Converted to a jQuery plugin
@jordansinger jordansinger merged commit 7bc1f81 into jordansinger:master Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite reloading
3 participants