Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #140

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Spelling #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7212484
spelling: because
jsoref Dec 27, 2018
6f108b0
spelling: expected
jsoref Dec 27, 2018
7d91502
spelling: mildenstein
jsoref Dec 27, 2018
357f2f4
spelling: preferably
jsoref Dec 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* systemd platform now defaults to targeting /etc/systemd/system for writing
unit files. This was chosen based on research across across 7 different
Linux distributions.
* fix a bug where attempting to detect systemd would crash becuase
* fix a bug where attempting to detect systemd would crash because
`systemctl` was not available.

== 0.0.21 (May 16, 2016)
Expand All @@ -45,7 +45,7 @@
* Fix bug in OS detection

== 0.0.18 (May 6, 2016)
* Support newer Facter api (Aaron Mildtenstein)
* Support newer Facter api (Aaron Mildenstein)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jordansissel/pleaserun/blame/7621b9889b79025364ee52fb7b58f4abf2dc7b75/CHANGELOG.asciidoc#L48
https://github.com/jordansissel/pleaserun/blame/7621b9889b79025364ee52fb7b58f4abf2dc7b75/CHANGELOG.asciidoc#L51

https://www.google.com/search?q=Aaron+Mildtenstein

Showing results for Aaron Mildenstein

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@untergeek


== 0.0.17 (May 4, 2016)
* Added detection for Fedora 22 and 23, OS X 10.11, and Ubuntu 14.10, 15.04, 15.50, and 16.04. (#98, Aaron Mildenstein)
Expand Down
2 changes: 1 addition & 1 deletion lib/pleaserun/configurable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def all_attributes
#
# Both validation and munge blocks are optional.
#
# The 'validate' block is expcted to fail if the value given to the
# The 'validate' block is expected to fail if the value given to the
# facet is not valid.
#
# The 'munge' block is intended to help you coerce a value. For example, if
Expand Down
2 changes: 1 addition & 1 deletion spec/pleaserun/platform/sysv_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
etc_initd_writable = File.stat("/etc/init.d").writable? rescue false
p :WRIT => etc_initd_writable
if !etc_initd_writable
it "cannot write to /etc/init.d, so there's no deployment test to do. To run these tests, you'll need to run this as root, and preferrably in a vm or other temporary system"
it "cannot write to /etc/init.d, so there's no deployment test to do. To run these tests, you'll need to run this as root, and preferably in a vm or other temporary system"
else
it_behaves_like PleaseRun::Platform do
let(:skip) { "Cannot write to /etc/init.d" } unless etc_initd_writable
Expand Down