Fix for invoices without expiry tag #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsbaars
force-pushed
the
feature/fix-no-expiry-tag
branch
from
1a8c242 to
0ae82ed
Compare
Signed-off-by: Djuri Baars <[email protected]>
dsbaars
force-pushed
the
feature/fix-no-expiry-tag
branch
from
0ae82ed to
2894f97
Compare
|
Hi @dsbaars - thanks for your contribution, much appreciated. I'd like to keep the codebase fully covered by unit tests, so I can trust it's behavior between different PHP versions. Would you be so kind to write a unit test to test this specific scenario? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOLT11 specification allows that invoices do not have an explicit expiry tag: https://github.com/lightning/bolts/blob/master/11-payment-encoding.md#tagged-fields
This pull request falls back to the specified default so depending methods do not return
null.Unfortunately I don't have a way to generate a bolt11 to test this, otherwise I would add it.