fix: #3259 revert the duplicate symbolicEqual definition and just e…

…xport the existing definitions
josdejong · Sep 4, 2024 · 8d244d2 · 8d244d2
1 parent 143a8b7
commit 8d244d2
Showing 1 changed file with 9 additions and 27 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -1041,15 +1041,6 @@ export interface MathJsInstance extends MathJsFactory {
   simplifyConstant(expr: MathNode | string, options?: SimplifyOptions): MathNode
   simplifyCore(expr: MathNode | string, options?: SimplifyOptions): MathNode
 
-  /**
-   * Attempts to determine if two expressions are symbolically equal.
-   */
-  symbolicEqual(
-    expr1: MathNode,
-    expr2: MathNode,
-    options?: SimplifyOptions
-  ): boolean
-
   /**
    *  Replaces variable nodes with their scoped values
    * @param node Tree to replace variable nodes in
@@ -2559,15 +2550,15 @@ export interface MathJsInstance extends MathJsFactory {
   /**
    * Determines if two expressions are symbolically equal, i.e. one is the
    * result of valid algebraic manipulations on the other.
-   * @param {Node|string} expr1 The first expression to compare
-   * @param {Node|string} expr2 The second expression to compare
+   * @param {Node} expr1 The first expression to compare
+   * @param {Node} expr2 The second expression to compare
    * @param {Object} [options] Optional option object, passed to simplify
    * @returns {boolean} Returns true if a valid manipulation making the
    * expressions equal is found.
    */
   symbolicEqual(
-    expr1: MathNode | string,
-    expr2: MathNode | string,
+    expr1: MathNode,
+    expr2: MathNode,
     options?: SimplifyOptions
   ): boolean
 
@@ -4897,15 +4888,6 @@ export interface MathJsChain<TValue> {
     options?: SimplifyOptions
   ): MathJsChain<MathNode>
 
-  /**
-   * Attempts to determine if two expressions are symbolically equal.
-   */
-  symbolicEqual(
-    this: MathJsChain<MathNode>,
-    expr2: MathNode,
-    options?: SimplifyOptions
-  ): MathJsChain<boolean>
-
   /**
    * Calculate the Sparse Matrix LU decomposition with full pivoting.
    * Sparse Matrix A is decomposed in two matrices (L, U) and two
@@ -6160,17 +6142,16 @@ export interface MathJsChain<TValue> {
   /**
    * Determines if two expressions are symbolically equal, i.e. one is the
    * result of valid algebraic manipulations on the other.
-   * @param {Node|string} expr1 The first expression to compare
-   * @param {Node|string} expr2 The second expression to compare
+   * @param {Node} expr2 The second expression to compare
    * @param {Object} [options] Optional option object, passed to simplify
    * @returns {boolean} Returns true if a valid manipulation making the
    * expressions equal is found.
    */
   symbolicEqual(
-    this: MathJsChain<MathNode | string>,
-    expr2: MathNode | string,
+    this: MathJsChain<MathNode>,
+    expr2: MathNode,
     options?: SimplifyOptions
-  ): boolean
+  ): MathJsChain<boolean>
 
   /**
    * Test whether two values are unequal. The function tests whether the
@@ -7003,6 +6984,7 @@ export const {
   simplify,
   simplifyConstant,
   simplifyCore,
+  symbolicEqual,
   resolve,
   slu,
   usolve,