Normalizados saltos de línea al firmar

- Actualizada clase FacturaeSigner - Actualizados tests unitarios > Relacionado con #175
josemmo · Dec 7, 2024 · c0bc067 · c0bc067
1 parent 5412dd0
commit c0bc067
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Common/FacturaeSigner.php b/src/Common/FacturaeSigner.php
@@ -129,6 +129,10 @@ public function sign($xml) {
       throw new RuntimeException('Invalid signing key material: failed to read private key');
     }
 
+    // Normalize line breaks
+    $xml = str_replace("\r\n", "\n", $xml);
+    $xml = str_replace("\r", "\n", $xml);
+
     // Extract root element
     $openTagPosition = mb_strpos($xml, '<fe:Facturae ');
     if ($openTagPosition === false) {

diff --git a/tests/SignerTest.php b/tests/SignerTest.php
@@ -67,6 +67,16 @@ public function testCanSignValidDocuments() {
   }
 
 
+  public function testNormalizesLineBreaks() {
+    $xml = '<fe:Facturae xmlns:fe="http://www.facturae.es/Facturae/2014/v3.2.1/Facturae">' .
+      "    <test>This contains\r\nWindows line breaks</test>\n" .
+      "    <test>This contains\rclassic MacOS line breaks</test>\n" .
+      '</fe:Facturae>';
+    $signedXml = $this->getSigner()->sign($xml);
+    $this->assertStringNotContainsString("\r", $signedXml);
+  }
+
+
   public function testCannotTimestampWithoutTsaDetails() {
     $this->expectException(RuntimeException::class);
     $signer = new FacturaeSigner();