Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to handlebars v5 #1310

Merged
merged 4 commits into from
Feb 21, 2024
Merged

update to handlebars v5 #1310

merged 4 commits into from
Feb 21, 2024

Conversation

campeis
Copy link
Contributor

@campeis campeis commented Jan 28, 2024

updates handlebars to 5.1.1
version 5 simplified some lifetimes and introduced the use of RenderErrorReason to create RenderError. RenderError::new and other functions have been deprecated.

@christian-schilling christian-schilling enabled auto-merge (squash) January 28, 2024 21:59
auto-merge was automatically disabled January 29, 2024 01:41

Head branch was pushed to by a user without write access

@christian-schilling christian-schilling enabled auto-merge (squash) January 29, 2024 08:23
auto-merge was automatically disabled January 29, 2024 16:25

Head branch was pushed to by a user without write access

@campeis
Copy link
Contributor Author

campeis commented Feb 21, 2024

Looks like GHA failed at the build dev image step

@christian-schilling christian-schilling enabled auto-merge (squash) February 21, 2024 13:13
auto-merge was automatically disabled February 21, 2024 14:34

Head branch was pushed to by a user without write access

@christian-schilling christian-schilling merged commit 3b89f31 into josh-project:master Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants