Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether TmpGitNamespace request path exists before removing #1316

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

vlad-ivanov-name
Copy link
Collaborator

When TmpGitNamespace is dropped before any filtering / git work is done, for example due to an unrelated error, it will attempt to remove directory that doesn't exist because no code that actually uses the namespace path has run. This adds a check before remove_dir_all call to prevent tracing spam.

commit-id:9feb11b7

When TmpGitNamespace is dropped before any filtering / git work is done,
for example due to an unrelated error, it will attempt to remove
directory that doesn't exist because no code that actually uses the
namespace path has run. This adds a check before remove_dir_all call to
prevent tracing spam.

commit-id:9feb11b7
@vlad-ivanov-name vlad-ivanov-name merged commit 2851e36 into master Mar 7, 2024
2 checks passed
@vlad-ivanov-name vlad-ivanov-name deleted the only-remove-when-exists branch March 7, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants