Fix: reduce async runtime blocking #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to optimize request latency by reducing async runtime blocking * all functions of graphql objects are blocking, and many trigger file i/o. However, graphql requests were being executed via an async function. Use sync version of graphql execution and use tokio::spawn_blocking * use tokio::spawn_blocking for operations involving file i/o * reduce sync mutex lock regions where possible ### Performance * std::sync::Mutex should be very efficient when there's no contention, and none is expected in graphql routines * I've benchmarked the overhead of tokio::spawn_blocking, since it's used more now: on my computer (core i5 macbook) I can spawn and .await around 90k tasks per second, which is at least two orders of magnitude away from the number of requests Josh can currently handle per second. commit-id:bd8098e1
vlad-ivanov-name
force-pushed
the
fix-graphql-blocking
branch
from
d5305c3 to
8e1a7cd
Compare
christian-schilling
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize request latency by reducing async runtime blocking
Performance
commit-id:bd8098e1