Refactor: drop gitoxide from josh-core #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-ivanov-name
changed the title
vlad-ivanov-name
force-pushed
the
drop-gitoxide-from-core
branch
2 times, most recently
from
e867005 to
cb67e0e
Compare
christian-schilling
approved these changes
Jun 1, 2024
While gitoxide provides a well designed set of APIs, it's more oriented towards implementing a git client than a server, and it lacks some high-level APIs like treebuilder etc. Having it alongside the regular git2 implementation works but creates additional I/O pressure which has performance implications in scenarios when a lot of transactions are opened (graphql). It would still make sense to integrate gitoxide in the future as APIs improve, but only as a complete replacement of git2 and not side by side * Remove gix from josh-core * I kept gix in proxy since it still provides nice Rust APIs for repo init and config manipulation, however... * ...I updated the version of gix to latest and disabled all extra features, which reduced dependencies a lot
vlad-ivanov-name
force-pushed
the
drop-gitoxide-from-core
branch
from
cb67e0e to
742aa93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While gitoxide provides a well designed set of APIs, it's more oriented towards implementing a git client than a server, and it lacks some high-level APIs like treebuilder etc. Having it alongside the regular git2 implementation works but creates additional I/O pressure which has performance implications in scenarios when a lot of transactions are opened (graphql). It would still make sense to integrate gitoxide in the future as APIs improve, but only as a complete replacement of git2 and not side by side