Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump git2 dependency to 0.19 #1346

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung commented Aug 1, 2024

This fixes #1345.

Does it need a cache version bump? In my tests, this PR suffices to fix the issue even with an existing cache that was used for the previous "bad" conversion.

Copy link

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the RA issues.

Might be worth including a cargo update -p time to fix a build issue on recent compilers, but that's unrelated.

Copy link
Member

@christian-schilling christian-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a bump of CACHE_VERSION in cache.rs. In the case of this bug manifesting the resulting sha's will be different between versions and thus the cache cannot be kept from previous versions.

This means we no longer drop trailing "." in author names, so the cache version has to change.
@christian-schilling christian-schilling merged commit 953c432 into josh-project:master Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-roundtrip push to josh branch when a commit has a . as the last character of the author name
3 participants