feat: IndexedDB support #273
Conversation
Bumps [rollup-plugin-svelte](https://github.com/sveltejs/rollup-plugin-svelte) from 7.1.0 to 7.2.0. - [Changelog](https://github.com/sveltejs/rollup-plugin-svelte/blob/master/CHANGELOG.md) - [Commits](sveltejs/rollup-plugin-svelte@v7.1.0...v7.2.0) --- updated-dependencies: - dependency-name: rollup-plugin-svelte dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
- The persisted function is now deprecated, but remains functional - Instead of a storage option, there are now three seperate functions; localState, sessionState and indexedDBState - The localState and sessionState functions remain the same, aside from the storage parameter - indexedDBState is asynchronous and uses async/await (or callback) - Some refactoring was done, specifically with types PS: persisted() remains functional with the same API
There was a problem hiding this comment.
Generally speaking, and without reviewing every single change, I would say the change looks well done. Since the entries are separated functions, this should tree-shake well as far as I know. It would be ideal if tree-shaking tests could be added in order to verify that existing users won't get extra stuff in their bundles unnecessarily.
@joshnuss, do you have a roadmap as to when to get out of experimental versions? I see you have kept the versions experimental for a long time. What is the requirement to hit v1.0.0? I ask because this PR looks like a good candidate to hit it. Maybe you could also give this a round of release-candidate versions before becoming final (1.0.0-rc.1)? If you agree, maybe it is also time to get rid of writable()?
|
@intercepted16 thanks for the udpated PR, but please, don't continue unless @joshnuss says so. I just expressed my opinion in the form of a PR review. That's it. It is unclear to me if @joshnuss is even agreeable to adding this feature. |
|
@webJose Your changes were small, so I figured implementing them wouldn't hurt. |
|
@joshnuss Are you willing to add this feature? It's been a while with no response. |
|
Hi, I do t have a good answer right now. The next priority for the project is adding support for runes, so I'm not sure we should add more features right now. Is this an important requirement you're waiting on? |
|
@joshnuss Yes, I'd prefer to use the library for this; currently I'm using a custom solution. Maybe, as breaking changes are being implemented anyway, you could include this pull request in the runes change? |
|
I second (third) this PR/feature! |
Implement
IndexedDBsupport, useful for storing larger amounts of data.localState,sessionStateandindexedDBStatelocalStateandsessionStatefunctions remain the same, aside from the storage parameterindexedDBStateis asynchronous and uses async/await (or callback)PS:
persistedremains functional with the same API