Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter first pass #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

akhenakh
Copy link
Contributor

First pass at Go linters, also see #5

tests are passing

@joshuaferrara
Copy link
Owner

See my comment in #5 , but the gist of some of these unused variables seems to be that they're actually meant to be outputs of the function. Rather than deleting these, we should return them and set values appropriately wherever these functions are called. It'd be best to look over the C++ source code (specifically sgp4unit.cpp) at https://www.celestrak.com/publications/AIAA/2006-6753/ and modify the call/returns of functions where necessary such that the output values are piped throughout the algorithm correctly. This was a total oversight on younger-me's part...ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants