Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPS1 Carrier Air Wing sprite priority bug #157

Closed
PhantombrainM opened this issue Jun 6, 2020 · 16 comments
Closed

CPS1 Carrier Air Wing sprite priority bug #157

PhantombrainM opened this issue Jun 6, 2020 · 16 comments
Assignees
Labels
core bug Something isn't working

Comments

@PhantombrainM
Copy link

Yesterday I played Carrier Air Wing all 9 (or 10?) rounds with Continue dip on.

I noticed when the plane is fueled up (all three rounds or so?) that the pipes are flying through the air and I thought it looks weird.

So I opened Youtube and found the same behaviour but also some YT Vidoes without the problem. I think it's a bug.

Wrong (like on MISTer):
https://www.youtube.com/watch?v=ev1rgJm6uWw&t=545s

Seems right:
https://www.youtube.com/watch?v=T2ffq0MHzGI&t=306s

Also I lost control during the game at stage 7 or 8 (no control anymore and I died). Then I noticed I need to press start again and from that on I was player two (?) until the end of the game. Strange. I don't know why this happened and if it was a one time issue or not. Maybe I'll play it again tonight.

@jotego
Copy link
Owner

jotego commented Jun 8, 2020

This was originally issue jotego/jtcps#28 but it is described better here. There is a pic here:
https://clips.twitch.tv/IntelligentPiercingCoyoteFloof
The problem is that when I looked at the internal video signals, the drawing actually makes sense as it is. So I think I may be missing a piece of the puzzle. MAME gets this right but gets the NEMO letters wrong, which are very obvious too.
This will get sorted when I finally receive the EPROMs I've been waiting for.

The second issue you mentioned sounds more like a software problem. Maybe a different version of the game will work ok.

@c0d3h4x0r
Copy link

I just noticed the same bug and took a photo of it.

5F7EB667-22C7-4CEC-AD71-F0D26B04F378

@jotego
Copy link
Owner

jotego commented Dec 8, 2020

Technical notes:
Layer use:
SCR1 = text
SCR2 = big plane
SCR3 = clouds
OBJ = small plane and hoses
Control registers:
PRIO0 = 0000
PRIO1 = F7FF
PRIO2 = 03FE
PRIO3 = FFFF
Layer control = 6DA -> 110_1101_1010

@PhantombrainM
Copy link
Author

FYI. Tested. CPS 01/31/2021 Carrier Air Wing sprite priority glitch after 2rd Level is still present. But new DMA runs butter smooth now.

@asturur
Copy link

asturur commented Jul 28, 2021

Also the capcom arcade museum for consoles do this right. in the 30 June version of the core the bug is still present.
https://youtu.be/h2tOP2YdL2M?t=419

jotego referenced this issue in jotego/jtcps Dec 17, 2021
… look wrong. Maybe they are meant to be like that
@jotego
Copy link
Owner

jotego commented Dec 17, 2021

Fixed in 0fdcb02. But NEMO letters during the demo now look like in MAME. Maybe there are really supposed to be like that?

@jotego jotego closed this as completed Dec 17, 2021
@asturur
Copy link

asturur commented Dec 17, 2021

Oh wow is cool that is been fixed. What was the issue? Does it affects more than just carrier air wing and nemo?

jotego referenced this issue in jotego/jtcps Jun 25, 2022
Reopens issue #40
Closes #131 and #132
@jotego
Copy link
Owner

jotego commented Jun 25, 2022

The commit 0fdcb02 that fixed this issue, broke

@asturur
Copy link

asturur commented Jun 25, 2022

gonna have 2 copies of the core 😏

jotego referenced this issue in jotego/jtbin Jun 27, 2022
jotego/jtcps#132
jotego/jtcps#131
Breaks gain:
https://github.com/jotego/jtcps/issues/40

It also fixes the EEPROM saving in CPS 1.5, because only the lower half of the data was being saved. That seemed to be enough to get the settings working anyway...
@jotego jotego added the core bug Something isn't working label Nov 28, 2022
@jotego jotego transferred this issue from jotego/jtcps Feb 7, 2023
@asturur
Copy link

asturur commented Sep 14, 2023

Just to test i tried this game on the latest cps1 compiled core and nothing changed. I heard that there was some DTACK changes in the cpu of the core and i wonder if it could make any difference. it didn't.

@asturur
Copy link

asturur commented May 13, 2024

I tried the latest cps1 compilation from the github actions, the one with the fix for the dtack and cen, from this run https://github.com/jotego/jtcores/actions/runs/9055203490. The issue still persist.
Not that there was mention that it could have been fixed, but i guessed a little test was ok to do.

@paulb-nl
Copy link
Collaborator

The commit 0fdcb02 that fixed this issue, broke
"Three wonders" intro. See jotego/jtcps#131
Final Fight and Varth alignment. See jotego/jtcps#132

I am working on this issue. The jtcps repo is gone so I can't see the things that broke with your previous fix. What potential issues should I look at?

Now my changes fix this hoses issue and the Nemo heads animation is only inside the letters like Mame and 3wonders shows the gun in frame only like the pcb footage.

@asturur
Copy link

asturur commented Sep 12, 2024

I remember final fight had a stage where there was an elevator and the layers were messed up

@jotego
Copy link
Owner

jotego commented Sep 13, 2024

The commit 0fdcb02 that fixed this issue, broke
"Three wonders" intro. See jotego/jtcps#131
Final Fight and Varth alignment. See jotego/jtcps#132

I am working on this issue. The jtcps repo is gone so I can't see the things that broke with your previous fix. What potential issues should I look at?

Now my changes fix this hoses issue and the Nemo heads animation is only inside the letters like Mame and 3wonders shows the gun in frame only like the pcb footage.

I have made the original repo visible again, so the links work now. I will hide it again eventually because it creates confusion now that the source code for all cores is centralized in a single repo.

Thank you very much for looking at this. I am looking forward to your patch.

@paulb-nl
Copy link
Collaborator

Thanks Jotego. I sent the pull request with my changes.

I did not see any layer alignment issues during my testing.

jotego pushed a commit that referenced this issue Sep 15, 2024
-This fixes the fuel hoses priority bug in cawing #157
-Lou's gun in 3wonders is now only visible inside square frame #667
-Regression: Nemo heads animation is broken now and only visible inside the Nemo letters
@jotego
Copy link
Owner

jotego commented Sep 15, 2024

Fixed in #802 thanks to @paulb-nl. It introduces a regression in Nemo's animation, though.

@jotego jotego closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

6 participants