Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Final Fight: check layer alignment #132

Closed
jotego opened this issue Jun 4, 2022 · 2 comments
Closed

Final Fight: check layer alignment #132

jotego opened this issue Jun 4, 2022 · 2 comments

Comments

@jotego
Copy link
Owner

jotego commented Jun 4, 2022

Check whether this is correct

ffight

@atrac17
Copy link
Contributor

atrac17 commented Jun 19, 2022

The priority issues are present in other CPS1 titles. Final Fight is not the only title effected. I was able to trace this back to the last known working build.

Last working build is 20211206 (JTCPS1 v9f4b585).

20220619_100010-screen

20220614_202848-screen

Current build is 20220601 (JTCPS1 v40add73).

20220619_100535-screen

20220614_202659-screen

Traced back to the following commits:

4cef041
0fdcb02

@jotego
Copy link
Owner Author

jotego commented Jun 25, 2022

Thanks @atrac17 for providing the history information. I've reverted the compromising change in edd0cb9. This fixes this issue but reopens jotego/jtcores#157.

@jotego jotego closed this as completed Jun 25, 2022
jotego added a commit to jotego/jtbin that referenced this issue Jun 27, 2022
jotego/jtcps#132
jotego/jtcps#131
Breaks gain:
https://github.com/jotego/jtcps/issues/40

It also fixes the EEPROM saving in CPS 1.5, because only the lower half of the data was being saved. That seemed to be enough to get the settings working anyway...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants