Update dependencies #257
Merged
Update dependencies #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….2.10 Update @types/classnames: 2.2.9 → 2.2.10 (patch)
….9.8 Update @types/react-dom: 16.9.0 → 16.9.8 (patch)
…12.21 Update react-hot-loader: 4.12.12 → 4.12.21 (patch)
Update redux: 4.0.4 → 4.0.5 (patch)
…g-6.3.0 Upgrade @types/query-string: 6.1.1 → 6.3.0 (minor)
Update moment: 2.24.0 → 2.26.0 (minor)
Update less: 3.10.3 → 3.11.1 (minor)
…oard-5.0.2 Upgrade react-copy-to-clipboard: 5.0.1 → 5.0.2 (patch)
Update node-sass: 4.12.0 → 4.14.1 (minor)
…y-to-clipboard-5.0.2 Revert "Upgrade react-copy-to-clipboard: 5.0.1 → 5.0.2 (patch)"
Update typescript: 3.8.2 → 3.9.3 (minor)
Upgrade @types/bn.js: 4.11.2 → 4.11.6 (patch)
…1.47 Upgrade @types/crypto-js: 3.1.43 → 3.1.47 (patch)
…1.13 Update @types/webpack: 4.39.1 → 4.41.13 (minor)
…n/@babel/core-7.11.6 Update @babel/core: 7.10.5 → 7.11.6 (minor)
…n/ts-loader-8.0.4 Upgrade ts-loader: 8.0.1 → 8.0.4 (patch)
…n/tslint-6.1.3 Update tslint: 6.1.2 → 6.1.3 (patch)
…n/@types/react-16.9.49 Upgrade @types/react: 16.9.43 → 16.9.49 (patch)
…n/@types/semver-7.3.4 Upgrade @types/semver: 7.3.1 → 7.3.4 (patch)
…n/@types/node-14.11.2 Update @types/node: 14.0.27 → 14.11.2 (minor)
…n/copy-webpack-plugin-6.1.1 Update copy-webpack-plugin: 6.0.3 → 6.1.1 (minor)
…n/ts-node-9.0.0 Upgrade ts-node: 8.10.2 → 9.0.0 (major)
…n/typescript-4.0.3 Upgrade typescript: 3.9.7 → 4.0.3 (major)
…n/jdenticon-3.0.1 Upgrade jdenticon: 2.2.0 → 3.0.1 (major)
…n/less-loader-7.0.1 Upgrade less-loader: 6.2.0 → 7.0.1 (major)
|
ok, done. now only these issues are left:
Those should be done in separate pull requests. |
…n/file-loader-6.1.0 Update file-loader: 6.0.0 → 6.1.0 (minor)
…n/html-webpack-plugin-4.5.0 Upgrade html-webpack-plugin: 4.3.0 → 4.5.0 (minor)
…n/react-hot-loader-4.13.0 Update react-hot-loader: 4.12.21 → 4.13.0 (minor)
…n/query-string-6.13.4 Upgrade query-string: 6.13.1 → 6.13.4 (patch)
…n/husky-4.3.0 Upgrade husky: 4.2.5 → 4.3.0 (minor)
…n/webextension-polyfill-ts-0.20.0 Upgrade webextension-polyfill-ts: 0.19.0 → 0.20.0 (major)
…n/@babel/preset-env-7.11.5 Upgrade @babel/preset-env: 7.10.4 → 7.11.5 (minor)
wbobeirne
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Awesome work! Sorry for the delay.
- For the CSS Loader issue, I'm willing to bet it has something to do with style load order. I'll try to take a look there.
- Switching to ESLint sounds good, unfortunately in my experience with other projects it's got painfully slower, but I'd prefer that over falling behind. I may have to rework the rules a bit though.
- Ant design upgrade is going to suck, since they actually have changed the way things look a good bit. I'll have to stew on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running depfu against may fork to update all the dependencies and I will try to keep that branch up to date with latest releases.
Opening this PR in a reference to #255 - maybe the branch is helpful for some updates at some point
Feel free to close the PR.
Required code changes to update:
>in the HTML: 5132b61Object.assigninstead of spread operator: 2d1fe04Current issues:
tsc issues: https://travis-ci.org/github/joule-labs/joule-extension/builds/694760264#L225 - are those real errors? (mainly in: https://github.com/joule-labs/joule-extension/blob/develop/src/lnd/http/index.ts)Links regarding the TypeScript errors:
Version 3.4-dev breaks recursive types microsoft/TypeScript#30188“Type instantiation is excessively deep and possibly infinite” but only in a large codebase microsoft/TypeScript#34933https://stackoverflow.com/questions/57798016/how-to-ignore-type-instantiation-is-excessively-deep-and-possibly-infinite-tsIncorrect "'value' is specified more than once, so this usage will be overwritten. ts(2783)" microsoft/TypeScript#38535