SSL cert error instructions #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the InputAddress component.
wbobeirne
pushed a commit
that referenced
this pull request
Oct 13, 2020
Upgrade cross-env: 5.2.0 → 7.0.2 (major)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19.
What This Does
Improves the experience for users connecting to nodes (mainly local) that have self-signed certificates. It displays some text that explains what the error may be, and how to solve it. Unfortunately, there is no granularity to the information of why a requests failed (We just get "TypeError: Failed to fetch" which is the same error you get for many reasons.) So we just display the help text no matter what.
It's also worth noting that the instructions @brandoncurtis provided in #19 seemed to be OS-specific, so I went for the quick-and-easy approach of just telling the user to have the browser ignore the cert issue.
Ideally, this issue will be solvable in the future with either better extension permissions (Just ignore the cert error) or some better ssl cert procedure during lnd setup.
Screenshots