Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:refactor: Allow dynamic projectId in inbox log payload #1601

Merged
merged 1 commit into from
Nov 1, 2023
Merged

:refactor: Allow dynamic projectId in inbox log payload #1601

merged 1 commit into from
Nov 1, 2023

Conversation

aswetlow
Copy link
Member

Allows adding a dynamic projectId in Jovo Inbox logs

Can be set via jovo.$data._JOVO_INBOX_.projectId in an early middleware like before.request.start

Proposed Changes

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit 10e80cf into v4/dev Nov 1, 2023
6 checks passed
@aswetlow aswetlow deleted the v4/feat/inbox-dyn-project-id branch November 1, 2023 08:23
@aswetlow aswetlow mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswetlow @jankoenig