✨ Add Alexa generic locale merging in manifest #1607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This change merges
privacyAndCompliance
andpublishingInformation
of thegenericLocale
into thelocale
.Using this
ProjectConfig
:The generated
en-US
locale inpublishingInformation.locales
looks like this (no update description):After the changes of this branch it will merge in the generic locale, to look like this
As can be seen, this change merges the generic locale with the specific locale, where the specific locale properties override the generic ones. If neither generic nor specific locales are set, the default publishingInfos and pricavyAndCompliance will be set.
As the
checkLocales
function increased further in size, I refactored this function for easier readability.I tested this with multiple cases I could think of, and could not find any issues, if you find a weak spot, please let me know!
Types of Changes
Checklist