Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix not awaiting BigQuery addEventFilter #1632

Merged
merged 2 commits into from
May 14, 2024
Merged

🐛 Fix not awaiting BigQuery addEventFilter #1632

merged 2 commits into from
May 14, 2024

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This addresses an issue, where providing a async function for addEventFilter in the BigQueryAnalyticsPluginConfig, see here, never filters out the event, as it is not awaiting the result but treating the returned Promise as truthy

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit 0f94465 into jovotech:v4/dev May 14, 2024
3 checks passed
@aswetlow aswetlow mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswetlow aswetlow aswetlow approved these changes

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadlowskij @jankoenig @aswetlow