Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.7 + Django 2 #107

Merged
merged 33 commits into from
Dec 26, 2019
Merged

Python 3.7 + Django 2 #107

merged 33 commits into from
Dec 26, 2019

Conversation

jpadilla
Copy link
Owner

NOT READY TO MERGE

@rnegron Started working on this, still haven't gone through everything but we're almost there!

@jpadilla jpadilla mentioned this pull request Aug 30, 2018
Closed
@jpadilla jpadilla mentioned this pull request Sep 9, 2018
Closed
@rnegron
Copy link
Collaborator

rnegron commented Nov 6, 2018

Started on some unittests (#16). There doesn't seem to be anything blocking Python 3.7 at first glance. More testing would be good (forms, views, plus some integration tests with Selenium?)

@jpadilla
Copy link
Owner Author

jpadilla commented Nov 6, 2018

giphy

Awesome work! Honestly, I wouldn't really invest the time/resources on integration tests with Selenium or with too many unit tests, just cover some of the most critical paths and that's it. Just enough to help with maintenance. Newer features should ideally have some tests as well.

@jpadilla
Copy link
Owner Author

@rnegron que hacemos con esto, merge/deploy it?

@rnegron
Copy link
Collaborator

rnegron commented Dec 17, 2018

Este fin de semana le hecho un vistazo y hago algunos otros unittests. Luego de eso lo podemos merge yo creo

@rnegron
Copy link
Collaborator

rnegron commented Dec 24, 2018

Updated some packages that pipenv check gave warnings about. For the "django-storages" update, a new env var AWS_DEFAULT_ACL should be set on the deploy environment! Didn't get a chance to add more unittests, but will soon

jpadilla and others added 23 commits December 26, 2019 10:32
@jpadilla @rnegron
Initial work on updating to Django 2.x
d351392
@rnegron
Add factories for Comments, Departments, Professors, Universities, Users
d481780
@rnegron
Update Django 2.1 -> 2.1.3, install factory-boy
6cfeb6a
@rnegron
Apply isort
428e2b9
@rnegron
Fix typo in comment, fix UniversityFactory
c3e2ae6
@rnegron
Add model tests for comments, departments, professors and universities
6a166ff
@rnegron
Update travis file for Python 3.7
1253cfe
@rnegron
Add some model unittest to user app
1c08349
@rnegron
Python 3.7 is not yet available in main travis builds... Apply workar…
0a0c5fd 
…ound to get it early (travis-ci/travis-ci#9069 (comment))
@rnegron
Apply isort to pass build
88bc437
@rnegron
Update Django, django-storages and Werkzeug. Add some f-strings. isor…
23ee50f 
…t a file. Add AWS_DEFAULT_ACL to settings
@rnegron
Pass isort
33bde56
@rnegron
Update packages
de7b144
@rnegron
Fix breaking base_name change
d709356
@rnegron
Update runtime
f16d6a6
@rnegron
Update packages
4a07f2e
@rnegron
Fix whitenoise package
0750fcd
@rnegron
Add testing to docker entrypoint
7a92d0c
@rnegron
Add custom test command / overwrite
5cdc486
@rnegron
ugettext -> gettext
52296fe
@rnegron
Add black and isort to dependencies
a4cfc01
@rnegron
black + isort
b1407a4
@rnegron
Upgrade isort/black settings, exclude migrations
2869c18
@rnegron
Copy link
Collaborator

rnegron commented Dec 26, 2019 •
edited
Loading

1 year later! @jpadilla What do you think? I got passing tests on my side.

@jpadilla jpadilla merged commit 1c2f94d into master Dec 26, 2019
@jpadilla jpadilla deleted the django2 branch December 26, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpadilla @rnegron