Skip to content

Commit

Permalink
[WHM] Adjust overheals and update modules with new heals (xivanalysis…
Browse files Browse the repository at this point in the history
…#2027)

* [WHM] Adjust overheals and update modules with new heals (really only one mention of Medica)

* Remove direct Medica2/3 heals from the HoT bucket, as they are to be considered normal overheal
  • Loading branch information
Dot-Inni authored Jul 22, 2024
1 parent ba5991c commit 4b5776b
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 17 deletions.
1 change: 0 additions & 1 deletion locale/de/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion locale/en/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion locale/fr/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion locale/ja/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion locale/ko/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion locale/zh/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 11 additions & 10 deletions src/parser/jobs/whm/modules/Overheal.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Trans} from '@lingui/react'
import {Overheal as CoreOverheal} from 'parser/core/modules/Overheal'
import {Overheal as CoreOverheal, SuggestedColors} from 'parser/core/modules/Overheal'
import React from 'react'

export class Overheal extends CoreOverheal {
Expand All @@ -9,25 +9,26 @@ export class Overheal extends CoreOverheal {
override displaySuggestion = true

override trackedHealCategories = [
{
name: 'Assize',
trackedHealIds: [this.data.actions.ASSIZE.id],
ignore: true,
},
{
name: <Trans id="whm.overheal.hot.name">Healing Over Time</Trans>,
color: '#157f1f',
color: SuggestedColors[1],
trackedHealIds: [
this.data.statuses.REGEN.id,
this.data.actions.MEDICA_II.id,
this.data.statuses.MEDICA_II.id,
this.data.actions.ASYLUM.id,
this.data.statuses.ASYLUM.id,
this.data.statuses.MEDICA_III.id,
this.data.statuses.DIVINE_AURA.id,
],
},
{
name: <Trans id="whm.overheal.assize.name">Assize</Trans>,
color: '#12ba45',
trackedHealIds: [this.data.actions.ASSIZE.id],
},
{
name: <Trans id="whm.overheal.liturgyofthebell.name">Liturgy of the Bell</Trans>,
color: '#00b5ad',
color: SuggestedColors[2],
trackedHealIds: [
this.data.actions.LITURGY_OF_THE_BELL_ON_DAMAGE.id,
this.data.actions.LITURGY_OF_THE_BELL_ON_EXPIRY.id,
Expand All @@ -36,7 +37,7 @@ export class Overheal extends CoreOverheal {
},
{
name: <Trans id="whm.overheal.afflatus.name">Afflatus Healing</Trans>,
color: '#a0eade',
color: SuggestedColors[3],
trackedHealIds: [
this.data.actions.AFFLATUS_RAPTURE.id,
this.data.actions.AFFLATUS_SOLACE.id,
Expand Down
2 changes: 1 addition & 1 deletion src/parser/jobs/whm/modules/Thinair.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class Thinair extends Analyser {

return <Fragment>
<p><Trans id="whm.thinair.messages.explanation">
The main use of <ActionLink {...this.data.actions.THIN_AIR} /> should be to save MP on high MP-cost spells. Don't be afraid to hold it and lose a use over the fight as long as it covers an MP-heavy spell such as usages of <ActionLink {...this.data.actions.MEDICA_II}/>, <ActionLink {...this.data.actions.CURE_III}/>, and <ActionLink {...this.data.actions.RAISE} />. Usages that did not save a considerable amount of MP are marked red.
The main use of <ActionLink {...this.data.actions.THIN_AIR} /> should be to save MP on high MP-cost spells. Don't be afraid to hold it and lose a use over the fight as long as it covers an MP-heavy spell such as usages of <ActionLink {...this.data.actions.MEDICA_III}/>, <ActionLink {...this.data.actions.CURE_III}/>, and <ActionLink {...this.data.actions.RAISE} />. Usages that did not save a considerable amount of MP are marked red.
</Trans></p>
{thinairDisplay}
</Fragment>
Expand Down

0 comments on commit 4b5776b

Please sign in to comment.