Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic http source #532

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Generic http source #532

merged 2 commits into from
Nov 24, 2023

Conversation

DavieReid
Copy link
Contributor

Now that the transformer is optional in the http source, it is possible for this source to return something other than a Page[].

This PR exposes a generic createHTTPSource function that allows users to specify the response type

@DavieReid DavieReid requested a review from a team as a code owner November 24, 2023 11:23
Copy link

changeset-bot bot commented Nov 24, 2023

⚠️ No Changeset found

Latest commit: 99a805f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview Nov 24, 2023 11:23am

@DavieReid DavieReid merged commit bfb8138 into main Nov 24, 2023
7 checks passed
@DavieReid DavieReid deleted the generic-http-source branch November 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants