review comments

jpmorganchase · Jul 16, 2024 · 8b49736 · 8b49736
1 parent fcd6ed7
commit 8b49736
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 10 deletions.
diff --git a/packages/lab/src/system-status/SystemStatus.tsx b/packages/lab/src/system-status/SystemStatus.tsx
@@ -9,10 +9,7 @@ import systemStatusCss from "./SystemStatus.css";
 
 export interface SystemStatusProps extends HTMLAttributes<HTMLDivElement> {
   /**
-   * Emphasize the styling by applying a background color: defaults to false
-   */
-  /**
-   *  A string to determine the current state of the SystemStatus
+   *  A string to determine the current state of the SystemStatus. Defaults to `info`.
    */
   status?: ValidationStatus;
 }

diff --git a/packages/lab/src/system-status/SystemStatusActions.css b/packages/lab/src/system-status/SystemStatusActions.css
@@ -2,5 +2,4 @@
   margin-bottom: auto;
   display: flex;
   gap: var(--salt-spacing-100);
-  min-height: var(--salt-size-base);
-}
+}
diff --git a/packages/lab/stories/system-status/system-status.qa.stories.tsx b/packages/lab/stories/system-status/system-status.qa.stories.tsx
@@ -4,6 +4,10 @@ import {
   SystemStatusProps,
   SystemStatusContent,
 } from "@salt-ds/lab";
+import {
+  StackLayout,
+  Text
+} from "@salt-ds/core";
 import { Meta, StoryFn } from "@storybook/react";
 import { QAContainer } from "docs/components";
 
@@ -15,7 +19,14 @@ export default {
 const BasicSystemStatusExample: FC<SystemStatusProps> = ({ status }) => {
   return (
     <SystemStatus status={status}>
-      <SystemStatusContent>Example custom renderer</SystemStatusContent>
+      <SystemStatusContent>
+        <StackLayout gap={0.5}>
+          <Text color="inherit">
+            <strong>Title</strong>
+          </Text>
+          <Text color="inherit">Example custom renderer</Text>
+        </StackLayout>
+      </SystemStatusContent>
     </SystemStatus>
   );
 };

diff --git a/site/docs/components/system-status/usage.mdx b/site/docs/components/system-status/usage.mdx
@@ -46,12 +46,12 @@ import { SystemStatus, SystemStatusContent, SystemStatusActions } from "@salt-ds
 
 ### `SystemStatus`
 
-<PropsTable componentName="SystemStatus" />
+<PropsTable packageName="lab" componentName="SystemStatus" />
 
 ### `SystemStatusContent`
 
-<PropsTable componentName="SystemStatusContent" />
+<PropsTable packageName="lab" componentName="SystemStatusContent" />
 
 ### `SystemStatusActions`
 
-<PropsTable componentName="SystemStatusActions" />
+<PropsTable packageName="lab" componentName="SystemStatusActions" />