Skip to content

Commit

Permalink
Fix link colors in the Next theme
Browse files Browse the repository at this point in the history
  • Loading branch information
joshwooding committed Jan 13, 2025
1 parent a2fc9cf commit d074399
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 6 deletions.
10 changes: 10 additions & 0 deletions .changeset/silent-pigs-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@salt-ds/theme": minor
---

Deprecated foreground hover and active palette tokens.

| Deprecated token | Replacement token |
| ---------------------------------- | -------------------------------- |
| `--salt-palette-foreground-active` | `--salt-palette-accent-stronger` |
| `--salt-palette-foreground-hover` | `--salt-palette-accent-strong` |
12 changes: 12 additions & 0 deletions .changeset/sixty-seals-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@salt-ds/theme": patch
---

Updated content hover and active tokens so that they switch to Teal when using the Next theme.

```diff
- --salt-content-foreground-hover: var(--salt-palette-foreground-hover);
- --salt-content-foreground-active: var(--salt-palette-foreground-active);
+ --salt-content-foreground-hover: var(--salt-palette-accent-strong);
+ --salt-content-foreground-active: var(--salt-palette-accent-stronger);
```
4 changes: 2 additions & 2 deletions packages/theme/css/characteristics/content-next.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
--salt-content-bold-foreground: var(--salt-palette-foreground-primary-alt);
--salt-content-bold-foreground-disabled: var(--salt-palette-foreground-primary-alt-disabled);

--salt-content-foreground-hover: var(--salt-palette-foreground-hover);
--salt-content-foreground-active: var(--salt-palette-foreground-active);
--salt-content-foreground-hover: var(--salt-palette-accent-strong);
--salt-content-foreground-active: var(--salt-palette-accent-stronger);
--salt-content-foreground-visited: var(--salt-palette-foreground-visited);
--salt-content-foreground-highlight: var(--salt-palette-accent-weaker);
}
9 changes: 9 additions & 0 deletions packages/theme/css/deprecated/palette-next.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.salt-theme[data-mode="light"] {
--salt-palette-foreground-active: var(--salt-color-blue-700);
--salt-palette-foreground-hover: var(--salt-color-blue-600);
}

.salt-theme[data-mode="dark"] {
--salt-palette-foreground-active: var(--salt-color-blue-300);
--salt-palette-foreground-hover: var(--salt-color-blue-400);
}
4 changes: 0 additions & 4 deletions packages/theme/css/palette/foreground-next.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
.salt-theme.salt-theme-next[data-mode="light"] {
--salt-palette-foreground-active: var(--salt-color-blue-700);
--salt-palette-foreground-hover: var(--salt-color-blue-600);
--salt-palette-foreground-primary: var(--salt-color-black);
--salt-palette-foreground-primary-disabled: var(--salt-color-black-40a);
--salt-palette-foreground-primary-alt: var(--salt-color-white);
Expand All @@ -10,8 +8,6 @@
--salt-palette-foreground-visited: var(--salt-color-purple-800);
}
.salt-theme.salt-theme-next[data-mode="dark"] {
--salt-palette-foreground-active: var(--salt-color-blue-300);
--salt-palette-foreground-hover: var(--salt-color-blue-400);
--salt-palette-foreground-primary: var(--salt-color-white);
--salt-palette-foreground-primary-disabled: var(--salt-color-white-40a);
--salt-palette-foreground-primary-alt: var(--salt-color-white);
Expand Down
1 change: 1 addition & 0 deletions packages/theme/css/theme-next.css
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@

/* Deprecated */
@import url(deprecated/foundations-next.css);
@import url(deprecated/palette-next.css);

0 comments on commit d074399

Please sign in to comment.