design review comments addressed for site examples

.changeset/button-changes.md

@@ -2,25 +2,15 @@
 "@salt-ds/core": minor
 ---
 
-Added `color` and `appearance` prop for Button.
+Added `color` and `appearance` props for Button. These props replace the `variant` prop.
 
 ```tsx
-    <Button color="accent" appearance="solid">
-      Send <SendIcon aria-hidden />
-    </Button>
-    <Button color="accent" appearance="outline">
-      Send <SendIcon aria-hidden />
-    </Button>
-    <Button color="accent" appearance="transparent">
-      Send <SendIcon aria-hidden />
-    </Button>
-    <Button color="neutral" appearance="solid">
-      Send <SendIcon aria-hidden />
-    </Button>
-    <Button color="neutral" appearance="outline">
-      Send <SendIcon aria-hidden />
-    </Button>
-    <Button color="neutral" appearance="transparent">
-      Send <SendIcon aria-hidden />
-    </Button>
+    <Button color="accent" appearance="solid" />
+    <Button color="accent" appearance="outline" />
+    <Button color="accent" appearance="transparent" />
+    <Button color="neutral" appearance="solid" />
+    <Button color="neutral" appearance="outline" />
+    <Button color="neutral" appearance="transparent" />
 ```
+
+_Note:_ Button's `variant` prop is now deprecated and will be removed in the next major version.

.changeset/dull-turtles-teach.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": minor
+---
+
+Update FormFieldHelperText to have status colors applied when `validationStatus` is applied to FormField.

.changeset/funny-rules-laugh.md

@@ -0,0 +1,12 @@
+---
+"@salt-ds/core": minor
+---
+
+Added `tertiary` variant to the `variant` prop for Card, LinkCard, InteractableCard and Panel.
+
+```tsx
+<Card variant="tertiary">Example of a Tertiary Card</Card>
+<LinkCard variant="tertiary">Example of a Link Card</LinkCard>
+<InteractableCard variant="tertiary">Example of a Interactable Card</InteractableCard>
+<Panel variant="tertiary">Example of a Tertiary Panel</Panel>
+```

.changeset/loud-avocados-teach.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": patch
+---
+
+Fixed Pagination button having an incorrect color on hover when theme next is enabled.

.changeset/mean-kids-marry.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": patch
+---
+
+Fixed list scroll when there is only one item in `ComboBox` and `Dropdown`.

.changeset/odd-candles-argue.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/theme": patch
+---
+
+Fixed `--salt-size-selectable` double defined in deprecated token list

.changeset/pretty-feet-dance.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": patch
+---
+
+Fixed ListBox not scrolling to the active item in some circumstances

.changeset/seven-rivers-fail.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": patch
+---
+
+Update gap to `--salt-spacing-75` for top aligned labels in `FormField`.

.changeset/short-plants-own.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/lab": minor
+---
+
+Replaced TrackerStep's `state` prop with new `stage` and `status` props. Valid `stage` values are `"pending"` and `"completed"`. Valid `status` values are `"error"` and `"warning"`.

.changeset/slimy-dragons-promise.md

@@ -0,0 +1,35 @@
+---
+"@salt-ds/theme": minor
+---
+
+Added tertiary variables in theme next theme
+
+```
+--salt-container-tertiary-borderColor
+--salt-container-tertiary-borderColor-disabled
+```
+
+Added tertiary variables in existing theme
+
+```
+--salt-container-tertiary-background
+--salt-container-tertiary-background-disabled
+--salt-container-tertiary-borderColor
+--salt-container-tertiary-borderColor-disabled
+```
+
+Added gray 30 and 50 fade background in fade.css
+
+```
+--salt-color-gray-30-fade-background
+--salt-color-gray-50-fade-background
+```
+
+Un-deprecated tertiary palette variables in characteristics.css and palette.css and added those to neutral.css
+
+```
+--salt-palette-neutral-tertiary-background
+--salt-palette-neutral-tertiary-background-disabled
+--salt-palette-neutral-tertiary-border
+--salt-palette-neutral-tertiary-border-disabled
+```

.changeset/tame-islands-tell.md

@@ -0,0 +1,5 @@
+---
+"@salt-ds/lab": minor
+---
+
+Update Dropdown classname to saltDropdownBase to fix them clashing with the dropdown in core

.github/renovate.json

@@ -5,7 +5,11 @@
   "packageRules": [
     {
       "groupName": "Mosaic",
-      "packagePatterns": ["^@jpmorganchase/mosaic"]
+      "matchPackagePrefixes": ["@jpmorganchase/mosaic"]
+    },
+    {
+      "groupName": "AG Grid",
+      "matchPackagePrefixes": ["@ag-grid"]
     }
   ]
 }

.github/workflows/build-storybook.yml

@@ -4,16 +4,12 @@ on:
     branches:
       - main
   pull_request:
-    types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
+    types: [opened, synchronize, reopened, labeled]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-permissions:
-  issues: write
-  pull-requests: write
-
 jobs:
   build-storybook:
     runs-on: ubuntu-latest
@@ -45,25 +41,16 @@ jobs:
           echo $BASE > ./METADATA/base
           echo $RUN_CHROMATIC > ./METADATA/run-chromatic
           echo $NO_TURBOSNAP > ./METADATA/no-turbosnap
+          echo $ISSUE_NUMBER > ./METADATA/issue-number
         env:
           DRAFT: ${{ github.event.pull_request.draft }}
           BRANCH_NAME: ${{ github.event.pull_request.head.label || github.ref_name }}
           BASE: ${{ github.event.pull_request.base.ref || github.ref_name }}
           RUN_CHROMATIC: ${{ contains(github.event.pull_request.labels.*.name, 'chromatic') }}
           NO_TURBOSNAP: ${{ contains(github.event.pull_request.labels.*.name, 'no turbosnap') }}
+          ISSUE_NUMBER: ${{ github.event.pull_request.number }}
       - uses: actions/upload-artifact@v4
         with:
           name: metadata
           path: ./METADATA
           retention-days: 1
-      - name: Remove Chromatic label
-        uses: actions/github-script@v7
-        if: contains(github.event.pull_request.labels.*.name, 'chromatic')
-        with:
-          script: |
-            await github.rest.issues.removeLabel({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              name: ["chromatic"]
-            });

.github/workflows/chromatic.yml

@@ -6,6 +6,10 @@ on:
     types:
       - completed
 
+permissions:
+  issues: write
+  pull-requests: write
+
 jobs:
   chromatic-deployment:
     if: ${{ github.event.workflow_run.conclusion == 'success' }}
@@ -43,6 +47,9 @@ jobs:
 
             const noTurbosnap = fs.readFileSync("./METADATA/no-turbosnap", "utf8").trim();
             core.setOutput("noTurbosnap", noTurbosnap);
+
+            const issueNumber = fs.readFileSync("./METADATA/issue-number", "utf8").trim();
+            core.setOutput("issueNumber", issueNumber);
       - name: Fetch base branch from upstream
         if: github.event.workflow_run.event == 'pull_request'
         run: |
@@ -67,7 +74,7 @@ jobs:
           run-id: ${{ github.event.workflow_run.id }}
       - name: Publish to Chromatic
         if: ${{ steps.chromatic_branch.outputs.branchName == 'main' || (steps.chromatic_branch.outputs.draft != 'true' && steps.chromatic_branch.outputs.runChromatic == 'true') }}
-        uses: chromaui/action@v11.3.5
+        uses: chromaui/action@v11.5.6
         # Chromatic GitHub Action options
         with:
           # 👇 Chromatic projectToken, refer to the manage page to obtain it.
@@ -85,3 +92,18 @@ jobs:
           debug: true
         env:
           LOG_LEVEL: "debug"
+      - name: Remove Chromatic label
+        if: ${{ steps.chromatic_branch.outputs.branchName != 'main' }}
+        uses: actions/github-script@v7
+        with:
+          script: |
+            try {
+              await github.rest.issues.removeLabel({
+                issue_number: ${{ steps.chromatic_branch.outputs.issueNumber }},
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                name: ["chromatic"]
+              });
+            } catch (error) {
+              console.log(error);
+            }

.github/workflows/release.yml

@@ -39,6 +39,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
 
       - name: Run Storybook build

.github/workflows/snapshot.yml

@@ -90,6 +90,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           COMMENT_ID: ${{ github.event.comment.id }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
         with: