Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify component theme next attributes, update spec and enable snapshot #3536

Closed
22 tasks done
origami-z opened this issue Jun 7, 2024 · 7 comments
Closed
22 tasks done
Assignees

Comments

@origami-z
Copy link
Contributor

origami-z commented Jun 7, 2024

Below components which has corner radius added. This is prerequisite for making SaltProviderNext stable

Theme next

  • (Assumed) new color palette
  • Corner
  • Accent (teal/blue)
  • Heading font
  • Action font

Need to verify they are defined in Figma spec, updated in Figma Salt (Next) library. Confirm code parity.

  • Update Figma component spec
  • Update Figma (Next) library
  • Update Corner token description (Figma)
  • Update Corner token description (code)
  • Create an issue to track Curve on Salt site foundation page

In code - https://storybook.saltdesignsystem.com/?path=/docs/experimental-theme-next--docs

In Figma - https://www.figma.com/design/qXEHyJjOEiPMHkrnvuV8xk/Salt-2-Border-radius?node-id=1307-9257&t=7cli6F5LR8CuGWnT-1

Existing components

Preview Give feedback

Stretch goal

Preview Give feedback
@mark-tate
Copy link
Contributor

Zazu Goal: L(11)

  • Border to be done by Darrin
  • Shadow to be done by Ben
  • By EOS we want to remove the unstable tag from Salt 2

@mark-tate
Copy link
Contributor

SoS Raised A Question:
@bhoppers2008 this story does not appear to be progressing ?
What is the new date for Salt 2 to become stable ?

@mark-tate
Copy link
Contributor

mark-tate commented Jul 8, 2024

Goal Complete all verification by EOS
Focus on corner to create a point of reference
Will require other styling options to be moved to a future sprint task (create issues for that work, broken down by styling option, if possible)

@navkaur76
Copy link
Contributor

9th July - attributes kick-off meeting w/ Zhihao + Darrin. Outcome: Nav to prioritise + update figma component specs for corner attributes across existing components, Darrin to take a look at the stretch goal components (prioritise dropdown/combo box and menu for Pepper team).

@navkaur76
Copy link
Contributor

17 Jul - components using corner radiuses verified in both design + code. Latest source of reference for design can be found in Border radius file.

@navkaur76
Copy link
Contributor

This ticket (3536) to be closed, and instead split into additional tickets to track the remaining theme Next attribute verification work. Refer to tickets #3834, #3835, #3836 and #3837.

@bhoppers2008 bhoppers2008 assigned origami-z and unassigned origami-z and dplsek Jul 19, 2024
@navkaur76
Copy link
Contributor

Closing ticket due to comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants