-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify component theme next attributes, update spec and enable snapshot #3536
Comments
Zazu Goal: L(11)
|
SoS Raised A Question: |
Goal Complete all verification by EOS |
9th July - attributes kick-off meeting w/ Zhihao + Darrin. Outcome: Nav to prioritise + update figma component specs for corner attributes across existing components, Darrin to take a look at the stretch goal components (prioritise dropdown/combo box and menu for Pepper team). |
17 Jul - components using corner radiuses verified in both design + code. Latest source of reference for design can be found in Border radius file. |
Closing ticket due to comment above. |
Below components which has corner radius added.
This is prerequisite for makingSaltProviderNext
stableTheme next
Need to verify they are defined in Figma spec, updated in Figma Salt (Next) library. Confirm code parity.
In code - https://storybook.saltdesignsystem.com/?path=/docs/experimental-theme-next--docs
In Figma - https://www.figma.com/design/qXEHyJjOEiPMHkrnvuV8xk/Salt-2-Border-radius?node-id=1307-9257&t=7cli6F5LR8CuGWnT-1
Existing components
Stretch goal
The text was updated successfully, but these errors were encountered: